search

anaconda-graveyard / nb_anacondacloud

Interact with Anaconda Cloud
BSD 2-Clause "Simplified" License
5 stars 9 forks source link

Uploading as ipynb type #4

Closed bollwyvl closed 8 years ago

bollwyvl commented 8 years ago

Fixes #3.

Unlike with the upstream there is no reason to even look at the file type, since we always know it will be an ipynb...

damianavila commented 8 years ago

LGTM... ping @malev for review as well...

malev commented 8 years ago

:+1:

bollwyvl commented 8 years ago

Cool, thanks! I probably need to do some more hacking around the thumbnails and environments... is there a good example of a notebook that was uploaded prior to me hitting things with wrenches that uses either of these features? I'm afraid I don't even know where to look to see what the server is expecting. I'll also try some anaconda notebook upload myself, but wouldn't mind some Known Good examples.

Had another idea, too, but will create an issue for it for discussion...

On Mon, Jan 11, 2016 at 4:01 PM Marcos Vanetta notifications@github.com wrote:

[image: :+1:]

— Reply to this email directly or view it on GitHub https://github.com/Anaconda-Server/nb_anacondacloud/pull/4#issuecomment-170688701 .

damianavila commented 8 years ago

I would merge this one but I don't have permissions, can you give permission @malev? Thanks!

damianavila commented 8 years ago

OK, let's merge things...