Closed bollwyvl closed 8 years ago
wow, lot of changes... ping @malev (I am always pinging Marcos because he wrote this extension and should be the best person to review this one). Btw, I will try to review in depth later, but looks nice from my top view...
the summary only populates on the initial upload
we can live with that for now...
I don't see where the thumbnails can be made to show up
what do you mean?
I don't see how environment attachment works, or how I would see it
Env attachment is provided by conda env attach
the summary only populates on the initial upload
we can live with that for now...
Turns out summary
is package level. There is also description
. will investigate
I don't see where the thumbnails can be made to show up
what do you mean?
the upload supports a thumbnail feature. I need to do some CLI tests to figure out how I might see it. It might get embedded somewhere I don't know about. But more importantly, I don't see where they actually show up in the AC UI... which is kind of the point. The user listing doesn't show them, while the landing page does.
I do see, however, that version is in there now... though it is a nasty GET string, which appears to be used all over:
http://notebooks.anaconda.org/nbcio/untitled?version=2016.01.14.1008
If I ruled the world, I would see this changed to...
http://notebooks.anaconda.org/nbcio/untitled/2016.01.14.1008/
or less pretty and invasive:
http://notebooks.anaconda.org/nbcio/untitled@2016.01.14.1008/
or adopt the turing-complete metalanguage of req.txt/env.ym/pkg.json:
http://notebooks.anaconda.org/nbcio/untitled@^2016.01.14.1008/
http://notebooks.anaconda.org/nbcio/untitled@<=2016.01.14.1008/
... but this is a discussion for @mmarchetti on another project.
I don't see how environment attachment works, or how I would see it
Env attachment is provided by conda env attach
Found the doc, will investigate more! I do wonder how in the AC or Notebook UI I can tell if an environment is attached, and what I can do with it. As I was saying, we'd want to promote this and get it integrated with binder's index.ipynb concept, obviating the need for an explicit environment.yml.
Better still would be if any launched notebook would be interrogated and used at kernel launch but that's a lot more integration work... and still wouldn't solve storing server extensions (it would be too late).
@bollwyvl if you run anaconda notebook upload your-notebook.ipynb --thumnail your-image.png
you'll have the thumbnail working.
BTW this looks amazing. Why aren't we merging this?
Everybody so buzy! I got distracted working on the test stuff (which will be mostly the same for this) over on #8. I've started the rebase of this work onto there, but figured i could do them in parallel. Either one is almost ready to merge, unless we keep moving the poles on Definition of Done :)
Right now deep in nbpresent build against The Matrix... this win-32/2.7 stuff is nuts! The success/failure there will inform getting this working, too!
OK, I think this is ready for now... if something else is needed, it can be done in another PR... merging now.
Digging around on some errors, I found a lot of places to clean up the overall flow of working with the form/backend.
anaconda-cloud
as the namespace for both the backend calls (vsac-*
) as well as for the frontend metadata: this is the generally accepted way to handle metadataanaconda-cloud
metadata objectIssues