Migrating `anaconda-linter` to the Packaging Automation Team Standards

anaconda / anaconda-linter

BSD 3-Clause "New" or "Revised" License

7 stars 1 forks source link

Migrating `anaconda-linter` to the Packaging Automation Team Standards #302

Closed schuylermartin45 closed 10 months ago

schuylermartin45 commented 11 months ago

percy and perseverance-scripts walked so anaconda-linter could run
Backports the configurations and learnings from our previous projects to provide a more consistent and convenient set of automated code checks
Not all of these rules will be enforced at this time. Expect an auto- formatter PR in the near term, but the pylint and mypy rules will be much futher down the line

schuylermartin45 commented 10 months ago

Some notes:

Added @marcoesters for visibility
Tests now run under the pre-commit checks, same as percy
I verified the output of the GitHub workflows. I have them all running in Python 3.9 for now.
There is a known issue having to deal with make versions that Charles ran into last week. I have a ticket (PAT-64) to track this problem.

schuylermartin45 commented 10 months ago

Following this PR, I plan to run the auto-formatter against the entire project and enforce those checks from now on.

schuylermartin45 commented 10 months ago

I don't know much about .pylintrc or .mypi.ini, so I didn't review those files.

Those files are more or less directly pulled from percy and perseverance-scripts so I'm not too worried. .pylintrc is a slightly modified version of the Google Python linting standard.