Closed AlbertDeFusco closed 3 years ago
Any reason not to call the subcommand "docker" instead of "dock"?
I'm not particularly partial. I used to "dock" since it is a verb like other commands (prepare, archive, etc.).
Maybe "dockerize" or "build-image"? What else might be a good name for this subcommand?
dock
, docker
, dockerize
, and docker-image
all sound fine to me (so I'm not much help!).
@jbednar , could you re-open this PR?
Ah. It looked like a shortening of docker. In my eyes, dock is less self-descriptive, dockerize
seems nice, but I'm not strongly opinionated either way. I was just a little confused by dock.
dockerize
it is then!
just a final sign off here. If one of you can review then go ahead and merge too!
Thanks! I'll add those changes first thing tomorrow
Recommended changes incorporated, thanks
This adds the
anaconda-project dockerize
command to create Docker images from projects. This will runs2i build
using the s2i-anaconda-project builder images by default.