search

anaconda / anaconda-project

Tool for encapsulating, running, and reproducing data science projects
https://anaconda-project.readthedocs.io/en/latest/
Other
217 stars 88 forks source link

Check if there is a progress bar before updating it #340

Closed maximlt closed 2 years ago

maximlt commented 2 years ago

Fixes #339

I have seen no existing infrastructure for testing this sort of thing. I tested it on the example reported in the issue and the fix worked fine.

jlstevens commented 2 years ago

@AlbertDeFusco Looks good to me!

As the original author of this functionality, are you happy to see this merged?

jlstevens commented 2 years ago

I suppose my only query is whether there are other error conditions other than the lack of the 'content-length' entry that we should know about (that mean the progress bar isn't created). Either way, this is definitely a more robust fallback.

maximlt commented 2 years ago

@jbednar why did you close it?

jlstevens commented 2 years ago

I think this is a horrible misfeature of GitHub!

Jim merged https://github.com/pyviz-topics/examples/pull/187 on pyviz-topics and Maxime mentioned this issue there. I think Github is closing issues automatically across projects upon merge just for mentioning issues!

jbednar commented 2 years ago

Crazy! Github seems to have decided that because PR 187 on pyviz-topics/examples says "fix" near a reference to this PR, somehow that PR would close this PR. Obviously that's an incorrect inference in this case, but it also seems inappropriate to assume any PR will close another PR.

AlbertDeFusco commented 2 years ago

Thanks for the PR. I'm going to look at getting the tests fixed and merge this.

AlbertDeFusco commented 2 years ago

I've fixed the test and added a changelog. This will be tagged as 0.10.2

maximlt commented 2 years ago

Thanks Albert!

On Mon, Sep 27, 2021 at 9:05 PM Albert DeFusco @.***> wrote:

I've fixed the test and added a changelog. This will be tagged as 0.10.2

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Anaconda-Platform/anaconda-project/pull/340#issuecomment-928186660, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISCWAWJ7KCCWT7WU7URWZ3UEC6AHANCNFSM5END2XCQ .