search

anaconda / anaconda-project

Tool for encapsulating, running, and reproducing data science projects
https://anaconda-project.readthedocs.io/en/latest/
Other
216 stars 88 forks source link

Add tdqm dependency for progress bars. Resolves #355. #356

Closed mforbes closed 2 years ago

mforbes commented 2 years ago

This is a minimal fix for issue #355. Note: after running the tests, many pieces of code were reformatted. I did not include these changes to keep the noise at a minimum. Should I first commit a lint revision with the reformatted code, then rebase my changes on top? (If so, this could be spelled out explicitly in CONTRIBUTING.md. Let me know and I can include in a future documentation PR.)

I am not comfortable enough with the project's CI to figure out why this error was not caught during CI. Does the CI provision from an environment that uses conda/meta.yml? If so, we might like to add some CI provisioning from environment.yml directly (for developers) and from setup.py (for people who install from pip).

mforbes commented 2 years ago

BTW: I could not run all of the tests: Things stalled at "anaconda_project/internal/test/test_conda_api.py::test_resolve_dependencies_with_actual_conda_other_platforms" with this step taking close to an hour. (Mac OS X 10.14.6).

I also failed anaconda_project/test/test_prepare.py::test_default_to_system_environ because my default ~/.condarc used auto_stack: 1 and I start with a base environment active, which caused some path changing issues. This may relate to #336 where better control over global conda configuration may be needed for reproducibility.

Can we easily run tests with a repeatable configuration? In the meantime, I will add an additional exception.

AlbertDeFusco commented 2 years ago

Approved!

AlbertDeFusco commented 2 years ago

I'll give it a try on my system with auto_stack: 1. I've opened a new issue for it #357

AlbertDeFusco commented 2 years ago

Ick, I have no idea what's up with tests. I've been having trouble with the Github actions for several weeks on this repo.

Anyway, #358 has some updates to CONTRIBUTING.md, more are certainly appreciated.