Allow environment names with one letter

anaconda / nb_conda

Conda environment and package access extension from within Jupyter

BSD 3-Clause "New" or "Revised" License

140 stars 32 forks source link

Allow environment names with one letter #37

Closed damianavila closed 7 years ago

damianavila commented 7 years ago

But also get rid of suspicious characters...

@martindurant provided this regex after some discussion at https://github.com/ContinuumIO/aen-issues/issues/680

damianavila commented 7 years ago

Well first commit was failing... it does not like the $ delimiter at the end of the regex... removing it fix the behavior and validate properly.... @martindurant thoughts?

coveralls commented 7 years ago

Coverage remained the same at 76.808% when pulling 2d5958484349b095ca097d13fcbe938deee10c06 on fix_regex_env into 3364053f09f07d77bc3c97a84f853d7c2986f7cb on master.

damianavila commented 7 years ago

OK, merging now... since appveyor is a queau for a long time...