Fix check updates feature

anaconda / nb_conda

Conda environment and package access extension from within Jupyter

BSD 3-Clause "New" or "Revised" License

140 stars 32 forks source link

Fix check updates feature #57

Closed fjcapdevila closed 7 years ago

fjcapdevila commented 7 years ago

check_update method wasn't working, probably because conda output changed.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 45.7% when pulling e2daf15e381edbc38d8bddffe32df8eeb3e6d125 on fix-check-update-method into 1c07319fb6618d6a69ba71c4d994f578dc98225a on master.

fjcapdevila commented 7 years ago

what are your doubts?

I repaired the backend, but now the frontend doesn't do anything with the results.

damianavila commented 7 years ago

I repaired the backend, but now the frontend doesn't do anything with the results.

OK... then we need to look into JS part :wink:

fjcapdevila commented 7 years ago

we need to look into JS part

I fixed the issue in JS.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 45.7% when pulling 6be84461661d094af93639f25cf2f2a9426d4413 on fix-check-update-method into 1c07319fb6618d6a69ba71c4d994f578dc98225a on master.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 45.7% when pulling 55aa994538b6c173fdbb3b5fd69bf6108f6c39a1 on fix-check-update-method into 1c07319fb6618d6a69ba71c4d994f578dc98225a on master.

damianavila commented 7 years ago

As a follow up, if we want to put this on the next AEN release we need to:

release nb_conda and upgrade nb_conda version in recipes

upgrade nb_conda patch in recipes containing the fix.

Second option is probably more quick and easy for now.