split windows/unix noarch

anaconda / nb_conda_kernels

Package for managing conda environment-based kernels inside of Jupyter

BSD 3-Clause "New" or "Revised" License

598 stars 70 forks source link

split windows/unix noarch #249

Closed mcg1969 closed 8 months ago

mcg1969 commented 8 months ago

Fixes #244

The packages are built on unix and windows, but tested on windows, mac, and linux. Uses the same technique as @mathause used here: https://github.com/conda-forge/nb_conda_kernels-feedstock/pull/52

So we're actually testing the build framework that conda-forge is trying to move to.

mathause commented 8 months ago

Nice! tldr: do you need to add psutil to meta.yml?

conda-forge/nb_conda_kernels-feedstock#54 suggesets that traitlets, psutil, and jupyter_core are missing from the dependencies in the meta.yml file, while pywin32 is superfluous*.

jupyter_client depends on traitlets and jupyter_core so these are in
psutil probably has to be added (was included in #233)
pywin32 is never imported, but might be needed anyway
I realise it's not the same meta.yml file...

mcg1969 commented 8 months ago

I will check! I saw those warnings over there too, but I think they are indirect dependencies.

mcg1969 commented 8 months ago

If we don't actually need pswin32 then we can go full noarch. But I don't think we can go without it.

mcg1969 commented 8 months ago

@mathause OK, I think this is the correct set of run dependencies:

    - python >=3.6
    - jupyter_client >=4.2
    - jupyter_core
    - setuptools
    - traitlets
    - psutil
    - __unix # [not win]
    - __win # [win]

I'm going to experiment with returning to true noarch, but first, I will update this.