search

anaconda / nbpresent

next generation slides for Jupyter Notebooks
BSD 3-Clause "New" or "Revised" License
162 stars 23 forks source link

[wip] Phantom tests #29

Closed bollwyvl closed 8 years ago

bollwyvl commented 8 years ago

This is for #28.

Still encountering some issues with anaconda-build environment.

bollwyvl commented 8 years ago

I am perilously close to getting the casper tests to run on anaconda cloud.

http://anaconda.org/nbcio/nbpresent/builds/85/1#L2457

it gets all the way to actually running the casper command and:

/opt/miniconda/conda-bld/test-tmp_dir/node_modules/phantomjs/lib/phantom/bin/phantomjs: error while loading shared libraries: libfreetype.so.6: cannot open shared object file: No such file or directory

If anyone (cc @mmarchetti @malev @damianavila @ijstokes) has any insight as to how it is best to ensure such libraries are available in the test environment, that would be extremely helpful. yum?

haven't tried the docker thing yet to see if that gives me more insight. it took me a while to realize how "clean" the environment is in which the tests are run, which made even starting stuff complex. adding a second package.json just for testing in conda.recipe seems to be working pretty well... and is good from a reuse/template point of view... i confess magic file names, nearly-duplicate keys in meta.yml, etc. are a little perplexing at times.

damianavila commented 8 years ago

If anyone (cc @mmarchetti @malev @damianavila @ijstokes) has any insight as to how it is best to ensure such libraries are available in the test environment, that would be extremely helpful. yum?

Did you try adding phantomjs into the test: requires: field in the conda recipe?

bollwyvl commented 8 years ago

Heh, not looking so good: http://anaconda.org/search?q=phantomjs

Nobody has a solid offering across all the platforms, and nobody has osx.

The (probably) last casperjs wants 1.9.8 i think: Nightmarejs has been recommended by the maintainer: http://www.nightmarejs.org/

(it does look very nice... es6 generators and all that)

But I REALLY want to be able to reuse the upstream tooling: https://github.com/jupyter/notebook/blob/master/notebook/tests/util.js#L640

Anyhow... I'll try with 1.9.7 (tonight) and see how that goes!

On Wed, Dec 9, 2015 at 9:11 AM Damián Avila notifications@github.com wrote:

If anyone (cc @mmarchetti https://github.com/mmarchetti @malev https://github.com/malev @damianavila https://github.com/damianavila @ijstokes https://github.com/ijstokes) has any insight as to how it is best to ensure such libraries are available in the test environment, that would be extremely helpful. yum?

Did you try adding phantomjs into the test: requires: field in the conda recipe?

— Reply to this email directly or view it on GitHub https://github.com/Anaconda-Server/nbpresent/pull/29#issuecomment-163248757 .

bollwyvl commented 8 years ago

Hooray, working build!

Still a lot more to test, but will continue to make progress!

damianavila commented 8 years ago

Hooray, working build!

Great!

bollwyvl commented 8 years ago

if the :green_heart: stays on, this is ready to go... i'm going to jump back on binder, and start getting that ready to go.

i did have to revert some of the setup stuff @damianavila, but when we get it working with nbsetuptools, we can address it.

damianavila commented 8 years ago

i did have to revert some of the setup stuff @damianavila, but when we get it working with nbsetuptools, we can address it.

nbsetuptools should address it :wink: