builds are really big - Githubissues

anaconda / nbpresent

next generation slides for Jupyter Notebooks

BSD 3-Clause "New" or "Revised" License

164 stars 24 forks source link

builds are really big #32

Closed bollwyvl closed 8 years ago

bollwyvl commented 8 years ago

I think some node_modules are slipping in. Probably don't need to ship the reference screenshots either... unless they are needed in the docs.

The next release needs to strip these out.

[ ] fix MANIFEST.in

damianavila commented 8 years ago

IIRC, I also saw that in you setup.py you are including data_files, and IIRC that put all the .git repo under the package... check if that if still happening...

bollwyvl commented 8 years ago

I thought this would handle that: https://github.com/Anaconda-Server/nbpresent/blob/master/MANIFEST.in#L17

damianavila commented 8 years ago

I did not check recently... this is just something I saw, let say, around 3 weeks ago... I will check later again...

bollwyvl commented 8 years ago

This has been fixed... there are perhaps still some issues when building locally, but the binstar build is clean.