search

anaconda / nbpresent

next generation slides for Jupyter Notebooks
BSD 3-Clause "New" or "Revised" License
162 stars 23 forks source link

true standalone html download/CLI #35

Closed bollwyvl closed 8 years ago

bollwyvl commented 8 years ago

The zip-based download approach is not that great from a user perspective, and makes server integration more complicated than it needs to be.

This PR (will) contain an updated HTML exporter that embeds its CSS and JS directly in the notebook.

Additionally, we'll want to be ready for nbconvert 4.2 which will likely obviate the need for the custom command line script... though it may be worth maintaining, in a simpler form, if it is more convenient for users/integrators.

bollwyvl commented 8 years ago

Added tests for exported HTML: still having some issues with font-awesome, considering just going with unicode chars for the navigation... but i can imagine wanting icons in my presentations, so it's probably worth inlining them.

bollwyvl commented 8 years ago

Hooray! Always unicode problems on anaconda cloud.... I wonder if this is a thing worth fixing with LOCALE?

I fixed up the unicode errors, and updated the doc, as we'll no longer offer the zip format...

bollwyvl commented 8 years ago

Once the linux and osx builds run, going to merge this, close https://github.com/Anaconda-Server/anaconda-nb-extensions/issues/39 and refocus efforts on https://github.com/Anaconda-Server/anaconda-nb-extensions/issues/135 (already in progress while waiting for builds)

bollwyvl commented 8 years ago

All :green_heart: for osx and linux-64.

I pronounce this done.... but we'll see what happens on master as I rejiggered the ci config.