search

anaconda / nbpresent

next generation slides for Jupyter Notebooks
BSD 3-Clause "New" or "Revised" License
162 stars 23 forks source link

Clean and add nb_config_manager, nbbrowserpdf dependency #38

Closed damianavila closed 8 years ago

damianavila commented 8 years ago

Removing old stuff... and enabling the CM to write in path instead of hardcoding the jupyter_config_dirRemoving old stuff... and enabling the CM to write in path instead of hardcoding the jupyter_config_dir. Also using nb_config_manager as a conda dependency (this should not affect people trying this with pip, but enforce people suing conda to use the custom config manager until this is fixed upstream in the notebook 4.2). I also added nbbrowserpdf as a dependency for nbpresent... I think the pdf exportation is important enough to ship it by default to the conda user.

bollwyvl commented 8 years ago

I would hold off on nbbrowserpdf for the moment. I have barely started testing it robustly.

Other option would be a metapackage, nbpresent-pdf, which did include it.

I have to review, for sure... will i have to leave all of my crufty stuff in for pip, or will it just work with nb_config_manager?

On Wed, Jan 27, 2016 at 10:17 AM Damián Avila notifications@github.com wrote:

Removing old stuff... and enabling the CM to write in path instead of hardcoding the jupyter_config_dirRemoving old stuff... and enabling the CM to write in path instead of hardcoding the jupyter_config_dir. Also using nb_config_manager as a conda dependency (this should not affect people trying this with pip, but enforce people suing conda to use the custom config manager until this is fixed upstream in the notebook 4.2). I also added nbbrowserpdf as a dependency for nbpresent... I think the pdf

exportation is important enough to ship it by default to the conda user.

You can view, comment on, or merge this pull request online at:

https://github.com/Anaconda-Server/nbpresent/pull/38 Commit Summary

  • Clean the path a little bit.
  • Add nb_config_manager as a conda-specific dependency. Also adding nbbrowserpdf as a dependency for PDF exportation.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Anaconda-Server/nbpresent/pull/38.

damianavila commented 8 years ago

I would hold off on nbbrowserpdf for the moment. I have barely started testing it robustly.

OK, removed...

Other option would be a metapackage, nbpresent-pdf, which did include it.

yep... I would expect a little bit for that... I can specify nbbrowserpdf in anaconda-nb-extension metapackage for now....

I have to review, for sure... will i have to leave all of my crufty stuff in for pip,

Yep... leave all the thing as is... I am not touching how the nbconfig is activated... we can use nbsetuptools in the future, but I would expect thing will be more easy after 4.2

or will it just work with nb_config_manager?

This extension will just work if you install it... because the nb_config_manager is aware of prefix/etc/jupyter...

bollwyvl commented 8 years ago

@damianavila Is my getting a release out (say, v0.5.1) on your critical path? I want to rebase #39 onto this, see if it breaks platforms I haven't accounted for, or has path weirdness. But i can get the incremental release out the door, if that would help you out!

damianavila commented 8 years ago

It would be nice to have 0.5.1 with this fix included... I have faith in you but I think the win build will give you a lot of problems yet and I would like to have the meta-package ready by end of week, if possible... (if you can also release nbbrowserpdf with the last PR merged, it would be awesome).

bollwyvl commented 8 years ago

@damianavila just kicked off the v0.5.1 upload build: https://anaconda.org/anaconda-nb-extensions/nbpresent/builds/25

These are still deploying to dev (which is good), but I don't see how i can create a main to move/copy them to... is that a thing as Benevolent Organizer For Life that you can do?

damianavila commented 8 years ago

These are still deploying to dev (which is good), but I don't see how i can create a main to move/copy them to... is that a thing as Benevolent Organizer For Life that you can do?

Yep... I can do it :wink: Thanks!!

damianavila commented 8 years ago

Can you release nbbrowserpdf as well and trigger a build in anaconda-nb-extensions?

bollwyvl commented 8 years ago

Can you release nbbrowserpdf as well and trigger a build in anaconda-nb-extensions?

Ah, indeed. Haven't touched that in a while, but will get on it.

damianavila commented 8 years ago

Thanks!