anaconda / percy

A tool to work on recipes from aggregate.
BSD 3-Clause "New" or "Revised" License
9 stars 0 forks source link

Parse Tree Implementation #47

Closed schuylermartin45 closed 1 year ago

schuylermartin45 commented 1 year ago

This is the initial parse tree work. There is a lot here, so here are some highlights:

It has:

It does not have:

Known bugs and feature improvements are being tracked in our board as JIRA Epic PKG-2787

schuylermartin45 commented 1 year ago

It appears linting is enforced to some degree by the package bots. I will see about getting pre-commit setup on my local machine. I was not aware that was enabled for this project.

Now some of this work uses 3.11/newer Python syntax. I don't think that should be an issue with the older versions as again, this isn't linked into any existing code and is a stand-alone file. We also talked about bumping our min version last week that would solve this issue.

schuylermartin45 commented 1 year ago

Now some of this work uses 3.11/newer Python syntax. I don't think that should be an issue with the older versions as again, this isn't linked into any existing code and is a stand-alone file. We also talked about bumping our min version last week that would solve this issue.

Well, okay, if the tests are set to run in GitHub actions, I guess that'd execute code that may not be compatible.

schuylermartin45 commented 1 year ago

I have been experimenting with incorporating the mypy and pylint learnings from perseverance-scripts into GitHub Actions today on this branch.

Once I finish the last few issues, I plan to merge those configuration changes into this PR. Or I'll make a second PR when this one gets merged.

schuylermartin45 commented 1 year ago

I ran pytest locally against 3.9 to validate the type annotations in 7742a4f

schuylermartin45 commented 1 year ago

Talked to Mark and Charles offline, we are good to merge!