search

anacrolix / fuse

FUSE for Go
Other
31 stars 8 forks source link

Get FUSE-T support stable #4

Open anacrolix opened 1 year ago

anacrolix commented 1 year ago

https://github.com/anacrolix/fuse/pull/2 and https://github.com/anacrolix/fuse/pull/3 added support for FUSE-T thanks to @macos-fuse-t. There are some rough edges to fix, this is a catch all issue for them as they come up.

anacrolix commented 1 year ago

@macos-fuse-t I see the os.File at the package scope were due to the GC closing file descriptors on us prematurely. I'm working to fix that.

anacrolix commented 1 year ago

I've fixed that in https://github.com/anacrolix/fuse/commit/d6c2a2991af73e65e858c1c46c3fe70288d21038.

anacrolix commented 1 year ago

@macos-fuse-t I've progressed this significantly. Feel free to fiddle with it, in particular you can set FUSE_FORCE_BACKEND=osxfuse or FUSE_FORCE_BACKEND=fuse-t to compare tests. go test -race -v ., and it's worth running the tests in github.com/anacrolix/torrent/fs, as well as test.sh from that same package (runs a production test which I have gotten working after some changes to torrent/fs to support FUSE-T idiosyncracies. Run the anacrolix/torrent stuff from https://github.com/anacrolix/torrent/compare/master...fuse-t.

macos-fuse-t commented 1 year ago

@anacrolix Thanks for the effort

anacrolix commented 1 year ago

It's not stable enough to use by default in anacrolix/torrent. I think this package still needs more work @macos-fuse-t

macos-fuse-t commented 1 year ago

Any concrete issues?

anacrolix commented 1 year ago

Nothing I could pin down. I'll put them here if I find anything. If you run with the instructions above you might get some insight.

macos-fuse-t commented 1 year ago

So just run the tests from github.com/anacrolix/torrent/fs and test.sh?

anacrolix commented 1 year ago

Yes

anacrolix commented 4 months ago

Was anyone able to do those tests?

v0.3.1 is now released.