Upgrade to pion/webrtc@v3

anacrolix / torrent

Full-featured BitTorrent client package and utilities

Mozilla Public License 2.0

5.48k stars 620 forks source link

Upgrade to pion/webrtc@v3 #451

Closed Sean-Der closed 2 years ago

Sean-Der commented 3 years ago

Hey @anacrolix

We just released v3 and would love to help you upgrade if you are interested.

v3 enables Trickle ICE users may see faster connection times now. They can connect to others before STUN resolves. This is a breaking change so I will need to figure out how WebTorrent emits/receives candidates.

anacrolix commented 3 years ago

Yes, let's give it a try. I'm keen to see if the write size limit issue that came up when streaming with DataChannels has been fixed too.

Sean-Der commented 3 years ago

The write size limit hasn't been fixed unfortunately. I don't even know how hard that would be to fix, let me look into that first. Hopefully I can come back to you with a dot release fixing that and then we can upgrade.

One annoyance is that it depends on remote support as well. Since the remote WebRTC peer may not support EOR you will still have to handle it.

anacrolix commented 2 years ago

This was contributed by @Sean-Der in https://github.com/anacrolix/torrent/pull/470.