search

anacrolix / torrent

Full-featured BitTorrent client package and utilities
Mozilla Public License 2.0
5.58k stars 630 forks source link

`torrent.WebseedPeerConns()` method #883

Closed AskAlexSharov closed 11 months ago

anacrolix commented 11 months ago

Was this ready to merge?

AskAlexSharov commented 11 months ago

Yes. Up to you.

AskAlexSharov commented 11 months ago

FYI: created branch release_v1.53.2 from tag v1.53.1, did cherry-pick this PR there, and tagged by v1.53.2 (also did push tag v1.52.60 by mistake. I deleted it).

AskAlexSharov commented 11 months ago

Did same thing: release_v1.52.7, v1.52.7

anacrolix commented 11 months ago

No worries. I'm roughly following semver, so this would be v1.54.0 if done correctly. v1.52.7 would be a bug fix, but the new method is a new feature, so it would be a minor version bump. Let me know if I have that incorrect.

anacrolix commented 11 months ago

We'll leave v1.52.7 as it is, but if I have semver right, next time that wouldn't be considered a bug (patch) fix.

AskAlexSharov commented 11 months ago

Right