search

anacrolix / torrent

Full-featured BitTorrent client package and utilities
Mozilla Public License 2.0
5.58k stars 630 forks source link

chore: clean up missinggo dependencies and formatting #976

Closed notCuteSocks closed 1 month ago

notCuteSocks commented 1 month ago

this PR includes:

anacrolix commented 1 month ago

Thanks. Not sure why the old dep was still there.

I can't fix the conflicts from my phone so I'll merge it tomorrow.

notCuteSocks commented 1 month ago

https://github.com/anacrolix/missinggo/blob/5da762c29f00b92d7525522865aef3d6b61974cc/go.mod#L8C2-L8C39

you forget to change from v1 to v2

anacrolix commented 1 month ago

I appreciate the PR but when I run it locally, the tests still fail.

notCuteSocks commented 1 month ago

https://github.com/anacrolix/torrent/issues/973#issuecomment-2373667792 yea, you need to fix the missinggo to make the test pass. This is only a temp fix for use.