search

anacrolix / utp

Use anacrolix/go-libutp instead
https://github.com/anacrolix/go-libutp
Mozilla Public License 2.0
173 stars 35 forks source link

panic in jitter #7

Closed whyrusleeping closed 8 years ago

whyrusleeping commented 8 years ago

Found a panic thrown in utp: https://gist.githubusercontent.com/dignifiedquire/33c5e9b5af4305491e37/raw/7c0c8731916bf8b21f723a8c1a32c2e1276bb993/fail.log

anacrolix commented 8 years ago

Thanks, I'll follow it up.

anacrolix commented 8 years ago

Are you trying your IPFS across localhost? This panic is caused when the latency in utp is determined to be 0. I never considered that that could happen, it seems incredibly unlikely. Unless maybe you have tests that can route packets without going through the kernel or something.

I'm going to move jitter into missinggo, and patch it up both in the JitterDuration and UTP codebases.

anacrolix commented 8 years ago

It's done. I am guessing your system time was set backwards, so that time.Now() and a later time.Now() decreased in value.

whyrusleeping commented 8 years ago

@anacrolix i don't know if that can happen. This was on a users computer (likely a macbook).

Thanks for the fix!