search

anacronw / multer-s3

multer storage engine for amazon s3
MIT License
660 stars 191 forks source link

[WIP] Use user supplied S3 instance #16

Closed LinusU closed 8 years ago

LinusU commented 8 years ago

This changes the functionality to use a user supplied s3 instance (aws.S3) instead of creating our own. That way you are free to authenticate in any way you like, plus set any additional options you may want.

Fixes #9

The tests probably could use some love, the good thing is that we no longer need to mock a server, but instead just the s3 instance. Take a look at the test code to see this in action.

I want to test all available options of all options and also try it with some different files. Another thing I noticed is that I reuse much of the code from multers test set, we should probably move all that to a separate package on npm and require from both parts.

anacronw commented 8 years ago

I made a PR at #26 with some small fixes

LinusU commented 8 years ago

Thanks man!! Sorry I dropped the ball on this one

anacronw commented 8 years ago

Hey no problem at all - you see like a busy guy ;)