anacronw / multer-s3

multer storage engine for amazon s3
MIT License
660 stars 190 forks source link

It could be ideal to add ACL for the uploads? :) #20

Closed jeremyrajan closed 8 years ago

jeremyrajan commented 8 years ago

It would be ideal, if the users are able to pass in ACL modes, during uploads :). Something like this:

  var upload = that.s3.upload({
        Bucket: that.options.bucket,
        Key: filePath,
        ACL: 'public-read', <-- // (passed via main func)
        ContentType: contentType,
        Body: (_stream || file.stream)
      })

ref: http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#listObjects-property

Something, we can pass it in a func. I can submit a pull request, with the change, if ok?

Cheers, Jeremy

anacronw commented 8 years ago

Duplicate of #11

Thanks for the PR, I think @LinusU was working on passing the entire option through to aws-sdk

LinusU commented 8 years ago

Yes, in #16, it's mostly done, just need to address the comments. I might be able to fix it this weekend 👏

jeremyrajan commented 8 years ago

great stuff thank you 👍