Implementing S3 Server-Side Encryption

anacronw / multer-s3

multer storage engine for amazon s3

MIT License

660 stars 190 forks source link

Implementing S3 Server-Side Encryption #66

Closed rvahudson closed 7 years ago

rvahudson commented 7 years ago

This is my first PR and open source contribution, so please be gentle if I haven't met requirements for contribution.

S3 has built-in server-side encryption that can be implemented via the API (docs here and here). This PR implements SSE using the S3-managed key system, as well as user-managed keys via KMS. I have not implemented Customer-Provided Keys (SSE-C) in this PR, but may at some point in the future.

rvahudson commented 7 years ago

@LinusU Keeping the naming in line with the S3 API makes sense. Suggested changes were made and pushed to this branch.

ChrisAlvares commented 7 years ago

@LinusU any chance this gets merged anytime soon?

LinusU commented 7 years ago

I feel that it's ready, let's give @badunk a few days to come with comments, otherwise I'll merge and release it

Feel free to remind me if I forget :)

anacronw commented 7 years ago

thanks for the tests!

rvahudson commented 7 years ago

Awesome, glad I could help!