search

anacronw / multer-s3

multer storage engine for amazon s3
MIT License
660 stars 190 forks source link

Switch order to provide properly magic-number-based mime to callbacks #77

Closed buffpojken closed 3 years ago

buffpojken commented 7 years ago

I found myself not wanting to rely on reported mime for calculating buckets and meta-data, but instead using the proper mime as determined by the magic number. Since that's already done anyway, switching the order of the independent ops makes it doable.

LinusU commented 3 years ago

Hey, sorry that no one ever took a look at your PR 😢

I think that this is better solved by upgrading to the release candidate of Multer 3.x. That version uses a different model where this will be available automatically.

The reason I don't want to just merge this now is that as it is it's an undocumented property, and I'm not sure that the name is the best since it's not always a "detected" mime type, since the user can supply any callback...

buffpojken commented 3 years ago

Well, I'm no longer even remotely connected to the project this was related to, so no worries I guess :)