anacronw / multer-s3

multer storage engine for amazon s3
MIT License
660 stars 190 forks source link

add options in opt object of multerS3 #78

Closed fedysalahserli closed 3 years ago

fedysalahserli commented 7 years ago

add options to make possible to override :

for more details see http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3/ManagedUpload.html#constructor-property

machbio commented 7 years ago

@badunk can you take a look at this..

afgarcia86 commented 6 years ago

👍 I need this.

Yaty commented 4 years ago

@badunk @LinusU what can I do to see this merged ?

machbio commented 4 years ago

@LinusU can this be merged ?

grimunit commented 4 years ago

Would love to be able to add tags upon upload, it's super critical to being able to correctly manage a lot of S3 objects

Zaimwa9 commented 4 years ago

+1 for merge ! Would be great

frames75 commented 4 years ago

Would love to be able to add tags upon upload, it's super critical to being able to correctly manage a lot of S3 objects

I fully subscribe to the above

alilland commented 3 years ago

tagging is absolutely a must, S3 has management rules to allow you to automatically purge or move files after X number of days

LinusU commented 3 years ago

Hey, sorry that no one ever took a look at your PR 😢

Unfortunately, I think that this is the wrong approach. All other options is mapped to a specific option to the Multer constructor, and also accepts function that can inspect the file before setting it. Pull requests that adds any or all of these options as a separate top level option could be accepted.

To everyone wanting this, I would recommend using the Multer 3.x release candidate instead which uses a different model where all of this can be solved very easy without this package at all!

Since this is so old I will close it, but happy to reopen if you want to change to individual options with support for callbacks.