search

anaderi / skygrid

Prototype project for SHIP grid-cloud framework developed in the context of CERN openlab summer school
2 stars 0 forks source link

Review #26

Open hushchyn-mikhail opened 8 years ago

hushchyn-mikhail commented 8 years ago

This is review 1. I have looked through the all code except YARN (I have to learn it). Basically, there are comments about descriptions of the code in this review. Especially, the executors code needs description (what is curved, flat ...). Also, It will be nice to have a general description of the Skygrid (what is skygrid, libscheduler, metascheduler, executors and so on).

I'II make more reviews, when I'II understand the code in details.

But generally, I like your code)

arogozhnikov commented 8 years ago

Mikhail,

  1. add .idea to gitignore and make sure those files are never stored in CVS
  2. comments can be added as comments in pull requests, not in code
hushchyn-mikhail commented 8 years ago

Alex, thanks for the comments.