search

anaestheticsapp / logbook

AnaestheticsApp Logbook
0 stars 3 forks source link

incorrect or unintuitive grouping of ages in reports #67

Open leoric23 opened 2 years ago

leoric23 commented 2 years ago

Hi Simon,

I'm not sure if I'm right so i'd like you to double check something i am struggling with.

I just tried getting a paediatrics report of all time from my account. I just used default age boundaries. I get a document with what seems to be all my paediatrics case numbers, but the grouping of ages inside of the report seems to be off. I feel like the data fetching works correctly for the ages, but the grouping is done on months instead of years.

If this is intended, i would like to have the option of either chosing to group by months or years. Or it should say if it is grouped by months or years in the corresponding pdf export.

Also it seems like in the date range selection in the reports page there is a formatting mistake in the text "Select the upper age boundaries" which shows as "Select the upper age boundaries.

Sorry if all of this is intended and i just understood it incorrectly.

Cheers and thanks again for this amazing app

anaestheticsapp commented 2 years ago

Hi sorry only just saw this.

Do you get the incorrect grouping when you selected "Paediatrics" as a module?

When selecting "Paediatrics", age groups won't be applied (intentional - will have to disable the box) but I noticed that the labels in the PDF table are wrong, they show the default age groups but when the "Paediatric" module is selected they should be "Days" "<6m" "<12m" "<5y" "<15y". This is already fixed but the update will be pushed out in a few days as I only pushed out an update today...

When selecting other modules, the age boundaries should be correct. Let me know if not!

The formatting "Select the upper age boundaries" is intentional but will be corrected as you suggested once I have implemented the new dialog modal for the logbook (the current ones doesn't allow formatting hence the wrid underscores).

leoric23 commented 2 years ago

Hey Simon,

no worries. Thanks for the fix in the PDF, now the numbers check out. :)

Disabling the age groups for "Paediatrics" module would also be useful if they aren't applied anyway.

Thanks for the fix.