search

anaganisk / digitalocean-dynamic-dns-ip

A simple script to automatically update Digital ocean DNS records with dynamic IP
Other
104 stars 22 forks source link

Dockerize and run in a loop #22

Closed tgrosinger closed 10 months ago

tgrosinger commented 1 year ago

These changes allow the application to run in a docker container in a loop. I decided to make a change to require that the config file be passed as a parameter.

I'm guessing you probably don't want all of these changes pulled in exactly like this, so please feel free to pick and choose if any of these changes are interesting to you. If not, please go ahead and close.

Thanks for doing the leg-work to get this setup!

anaganisk commented 1 year ago

Hi @tgrosinger thanks for the good additions in the PR, I will test it once soon on my machine, also requested a long time contributer @johnjaylward to review. I didnt yet review the code but, even if its a major jump, I dont think it will affect any current users since we dont distribute any updates and it wont affect any older versions. So it could be safe to merge if everything checks out.

anaganisk commented 1 year ago

@tgrosinger I think all checks out it worked on my machine, I will make the changes as @johnjaylward suggested an merge them.