search

anaganisk / digitalocean-dynamic-dns-ip

A simple script to automatically update Digital ocean DNS records with dynamic IP
Other
104 stars 22 forks source link

Allow setting custom IP check URLs #7

Closed cdzombak closed 5 years ago

cdzombak commented 5 years ago

This allows customizing the URLs used to fetch your current IP addresses via the configuration JSON file.

johnjaylward commented 5 years ago

Can you add a note about IP Check API requirements to the readme. Since it's configurable, you should mention the expectations that the code expects the API to return.

i.e.

The IP Check URL(s) should return the IP address as the body of the HTTP response to a GET request.

or something similar?

cdzombak commented 5 years ago

@johnjaylward done in https://github.com/anaganisk/digitalocean-dynamic-dns-ip/pull/7/commits/bf919c063b0efdd90c8030adee0307c7d2ec3978

johnjaylward commented 5 years ago

looks good, thanks