fix: Fix byte calculation in `download_public_input`, update validator and run-node scripts

anagrambuild / bonsol

solana + risc0

https://bonsol.sh

GNU Affero General Public License v3.0

60 stars 9 forks source link

fix: Fix byte calculation in `download_public_input`, update validator and run-node scripts #60

Closed dubbelosix closed 1 month ago

dubbelosix commented 1 month ago

Changes

Added a calculation fix for max_size, since it's passed in MB. changed the param name to max_size_mb and added a 1024*1024 in the call so the right byte count is passed
Quality of life improvements for
- validator.sh: Allow passing in additional programs using --bpf-program, since users might want to pass other programs (such as metaplex core). Made -r optional since we don't always want to wipe the local validator ledger
- run-node.sh: Added -F cuda as optional

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
bonsol	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 7:16pm

eureka-cpu commented 1 month ago

A quick unit test for the change to max_size_mb would be nice, but the change itself makes sense.

This looks fine to me but deferring approval to @austbot

dubbelosix commented 1 month ago

A quick unit test for the change to max_size_mb would be nice, but the change itself makes sense.

This looks fine to me but deferring approval to @austbot

@eureka-cpu I added a couple of test cases for valid and "Max size exceeded" errors using Mockito :) let me know if it looks ok!

eureka-cpu commented 1 month ago

@eureka-cpu I added a couple of test cases for valid and "Max size exceeded" errors using Mockito :) let me know if it looks ok!

Awesome, thank you 🙂 it looks great.

The CI check that's failing is due to the nightly formatting options, but you can run this to fix it:

rustup toolchain add nightly
cargo +nightly fmt

austbot commented 1 month ago

ill clean up fmt