feat: versioned execution - Githubissues

anagrambuild / bonsol

solana + risc0

https://bonsol.sh

GNU Affero General Public License v3.0

60 stars 9 forks source link

feat: versioned execution #88

Closed jac18281828 closed 3 weeks ago

jac18281828 commented 1 month ago

closes #29

This introduces a feature to manage risc0 versions. Each prover node will only prove from client execution requests that are sent to it from a compatible version of the client.

[x] client requests are tagged with a specific version
[x] mismatching versions are ignored at execution time
[x] logging is provided for incompatible versions
[x] changes are tested

Related Issues

85
32
87

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
bonsol	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 4:57pm

jac18281828 commented 3 weeks ago

This is ready for the next round of review. Cli is not defaulting to a specific prover version, it defaults to "DEFAULT" which maps to the current version in the contract. I will make another change to proof handing to require that a specific version of the prover is being used for the request.

jac18281828 commented 3 weeks ago

This should be ready to merge after one more round of manual testing...doing that now

jac18281828 commented 3 weeks ago

✅ confirmed proving is working

jac18281828 commented 3 weeks ago

My only question is why the simple image id changed, that should be stable across prover versions

Can you try running in your environment and determine if it is something peculiar to my environment?

jac18281828 commented 3 weeks ago

My only question is why the simple image id changed, that should be stable across prover versions

Okay, I discovered the issue. I was running cargo risczero --version 1.1.2 which is the current default install. I fixed that and it now matches. We should consider getting our examples updated to this latest default version.