anaisbetts / grunt-build-atom-shell

Grunt task to build Electron and rebuild node modules
MIT License
122 stars 11 forks source link

bootstrap.py error: error: unrecognized arguments: -y #37

Open lseongjoo opened 8 years ago

lseongjoo commented 8 years ago

System is as below:

node v0.12.2 electron v0.31.0

Running "build-atom-shell" task
>> usage: bootstrap.py [-h] [-u URL] [-v]
>> bootstrap.py: error: unrecognized arguments: -y
>> usage: bootstrap.py [-h] [-u URL] [-v]
>> bootstrap.py: error: unrecognized arguments: -y

Gruntfile.js as below:

module.exports = function(grunt){
  grunt.initConfig({
    'build-atom-shell':{
      tag: 'v0.19.5',
      nodeVersion: 'v.22.0',
      buildDir: (process.env.TMPDIR || process.env.TEMP || '/tmp') + '/atom-shell',
      projectName: 'codebasic',
      productName: 'CodeBasic',
      targetDir: './electron'
    }
  });

  grunt.loadNpmTasks('grunt-build-atom-shell');

  grunt.registerTask('default', ['build-atom-shell']);
};
lseongjoo commented 8 years ago

Changing tag value to v0.31.0 to match the electron version will do the job. Still, it might be better to check bootstrap arguments accordingly.

anaisbetts commented 8 years ago

Unless you need to run custom versions of Electron, you don't need to use this Grunt task, you should definitely use electron-prebuilt instead

lseongjoo commented 8 years ago

I need to use selenium webdriver for testing. Webdriver requires app's binary path so I am packaging it. Is there better way? If there is, I want to be informed. Thank you.

      1. 오전 1:18에 "Paul Betts" notifications@github.com님이 작성:

Unless you need to run custom versions of Electron, you don't need to use this Grunt task, you should definitely use electron-prebuilt instead

— Reply to this email directly or view it on GitHub https://github.com/paulcbetts/grunt-build-atom-shell/issues/37#issuecomment-134279842 .

anaisbetts commented 8 years ago

Have you seen https://github.com/atom/electron/blob/master/docs/tutorial/using-selenium-and-webdriver.md?

lseongjoo commented 8 years ago

Yes. When 3. Connect to chrome driver,

it seems that {chromeOptions: {binary: MyApp.app/Contents/MacOS/Atom}} requires the app's binary.

And I understand that the Workflow states that testing application w/o rebuilding is possible, but eventually I need to package my app. So I figure that Rebranding by rebuilding Elector from source applies. It says changing name from 'electron' is tedious so using grunt is better.

However, I've found this electron-packager http://git.io/vsyDN

I am reviewing this is the tool that I need. Can this be a way of doing things?

    1. 25., 오전 11:43, Paul Betts notifications@github.com 작성:

Have you seen https://github.com/atom/electron/blob/master/docs/tutorial/using-selenium-and-webdriver.md?

— Reply to this email directly or view it on GitHub.

anaisbetts commented 8 years ago

You should definitely use electron-packager

lseongjoo commented 8 years ago

Thank you, Paul.

    1. 25., 오후 12:19, Paul Betts notifications@github.com 작성:

You should definitely use electron-packager

— Reply to this email directly or view it on GitHub.