search

anaisbetts / grunt-build-atom-shell

Grunt task to build Electron and rebuild node modules
MIT License
122 stars 11 forks source link

default value for `nodeVersion` doesn't work #5

Closed cloderic closed 9 years ago

cloderic commented 9 years ago

... and, unless I've missed something, makes little sense.

The default value for the nodeVersion parameter is 0.20.0 which doesn't actually match any version of node.js.

I initially overlooked this and tried to use the task as-is on Mac (10.10.1) I ran into build issues that, after investigation, were linked to a download issue in node-gyp as it was trying to get version 0.20.0 of node.

I've now changed the value of the parameter to 0.10.33 (with a atom shell version of 0.20.0) and everything works fine. I'm still puzzled by this default value and also by the readme content.

Am I misunderstanding something ?

anaisbetts commented 9 years ago

Am I misunderstanding something ?

Yeah, Atom's node.js versions are different than the official ones. However, there was a bug in my code that caused us to download from the wrong place.

This should be fixed in the latest version 1.1.0 though, can you give it a try and reopen if it's still broken?

cloderic commented 9 years ago

Am I misunderstanding something ?

Yeah, Atom's node.js versions are different than the official ones. However, there was a bug in my code that caused us to download from the wrong place.

Indeed I overlooked that.

In any case I just tested with v1.1.0, the default value works fine! Thanks!

anaisbetts commented 9 years ago

@cloderic Great! Get in the habit of looking up that number whenever you bump the Atom Shell version, it does change from time to time.