search

anaisbetts / grunt-build-atom-shell

Grunt task to build Electron and rebuild node modules
MIT License
122 stars 11 forks source link

fix for use with atom-shell 0.20.3 #8

Closed ttilley closed 9 years ago

ttilley commented 9 years ago

make use of the new GYP_DEFINES method of setting project/product names fix a small typo in atom.gyp if found; bug only effects mac users fixes issue #7

anaisbetts commented 9 years ago

@ttilley Can you fix the typo in Atom Shell itself too?

ttilley commented 9 years ago

added https://github.com/atom/atom-shell/pull/966 for the typo

unindented commented 9 years ago

The fix was merged into atom-shell some days ago. @paulcbetts can we get this merged here too please?

anaisbetts commented 9 years ago

@unindented On it :) Gonna update atom-shell-starter too

unindented commented 9 years ago

Aaaawesome

unindented commented 9 years ago

Could we get a version bump in this project, to make use of the awesomeness?

anaisbetts commented 9 years ago

Already done!

unindented commented 9 years ago

Ah sorry, I was looking here instead of npm. I already see 1.1.5. Thank you!