search

anaisbetts / saveallthetime-atom

SaveAllTheTime makes it so you never commit files to Git without saving ever again
MIT License
1 stars 2 forks source link

Does this really have anything to do with git? #1

Closed mark-hahn closed 9 years ago

mark-hahn commented 9 years ago

"Automatically saves your document if your project uses Git"

Won't it work on projects without git?

anaisbetts commented 9 years ago

@mark-hahn It will, it just happens that you get trolled by Git more. In the original VS version, it also has real integration with Git that reminds you to commit more often, but I haven't ported that to Atom yet. The auto-save part does indeed work great regardless of SCM

mark-hahn commented 9 years ago

Webstorm (IntelliJ) always saved all the time. It didn't even give you an option. I got used to it. Very convenient to stop thinking about saving.

On Sat, Feb 21, 2015 at 5:32 PM, Paul Betts notifications@github.com wrote:

@mark-hahn https://github.com/mark-hahn It will, it just happens that you get trolled by Git more. In the original VS version, it also has real integration with Git that reminds you to commit more often, but I haven't ported that to Atom yet. The auto-save part does indeed work great regardless of SCM

— Reply to this email directly or view it on GitHub https://github.com/paulcbetts/saveallthetime-atom/issues/1#issuecomment-75412510 .

1j01 commented 9 years ago

You should change the description. "if" isn't appropriate, as it implies it won't save if you're not using git (or if it doesn't think you're using git at the moment), which would be some inconsistent behavior that I wouldn't want in my editor. (It made me hesitate to install, and come here.) You could change it to "..., good for if...", or whatever.

mark-hahn commented 9 years ago

it implies it won't save if you're not using git

If I understand what you are saying correctly then I should point out that this package does NOT save anything if you don't have git. I don't actually understand the logic but it's not my package.

It's on my list to fork this and do exactly what the name says.

On Wed, Apr 15, 2015 at 6:11 PM, Isaiah Odhner notifications@github.com wrote:

You should change the description. "if" isn't appropriate, as it implies it won't save if you're not using git (or if it doesn't think you're using git at the moment), which would be some inconsistent behavior that I wouldn't want in my editor. (It made me hesitate to install, and come here.) You could change it to "..., good for if...", or whatever.

— Reply to this email directly or view it on GitHub https://github.com/paulcbetts/saveallthetime-atom/issues/1#issuecomment-93610190 .

1j01 commented 9 years ago

Oh, I looked in the source and didn't see anything related to git, but it's just one mention of "repo", and the statement itself (@disp.setDisposable) doesn't sound anything like what I was looking for.

So, have you not already forked it and made it save all the time? What do you mean?

anaisbetts commented 9 years ago

I don't actually understand the logic but it's not my package.

I'm pretty sure you just disagree with the logic, because I explained it in a different bug :smile:. That being, that if you don't have source control, saving constantly can end up destroying data.

1j01 commented 9 years ago

@paulcbetts Most of the time I'd rather have a power outage and lose, say, my undo history, than any current changes. I personally feel much safer with autosave everywhere. (Not to say that autosave couldn't destroy files)

mark-hahn commented 9 years ago

saving constantly can end up destroying data.

That is the part I don't understand although I'm sure it is my fault. Saving inherently protects data. The english word "save" means to keep something.

I will take your word for it. Our workflows are obviously different. Might I suggest though that such a dangerous workflow should not be used?

On Wed, Apr 15, 2015 at 8:07 PM, Isaiah Odhner notifications@github.com wrote:

@paulcbetts https://github.com/paulcbetts Most of the time I'd rather have a power outage and lose, say, my undo history, than any current changes. I personally feel much safer with autosave everywhere.

— Reply to this email directly or view it on GitHub https://github.com/paulcbetts/saveallthetime-atom/issues/1#issuecomment-93625289 .

mark-hahn commented 9 years ago

I looked in the source and didn't see anything related to git, but it's just one mention of "repo", and the statement itself (@disp.setDisposable) doesn't sound anything like what I would expect.

At the present time, "repo" and "git" are synonymous in Atom. The disposable clearing and return statement stop all processing when github is not present and nothing is saved.

    unless atom.project.getRepo()
      @disp.setDisposable rx.Disposable.empty
      return