search

anaisbetts / saveallthetime-atom

SaveAllTheTime makes it so you never commit files to Git without saving ever again
MIT License
1 stars 2 forks source link

Package not activating automatically #6

Open mradzinski opened 8 years ago

mradzinski commented 8 years ago

On the latest stable Atom version to date (1.2.4) The following lines are preventing the package to auto-activate itself upon start.

unless atom.project.getRepositories().length
    @disp.setDisposable rx.Disposable.empty
    return

Removing/Commenting those lines fixes the issue.

anaisbetts commented 8 years ago

This is by-desgn, this code stops the package from loading if the project isn't backed by a Git repo, since saving automatically might actually result in users losing data

mradzinski commented 8 years ago

Well, actually the project I tried was a Git repo. I think there might be somehow of a racing condition. I tried debugging that part of the code through console logs and sometimes I see the project is recognised as a Git one and sometimes it's not.

anaisbetts commented 8 years ago

Oh, in that case that's deffo a bug, wonder if this is an ordering issue in package activation

mradzinski commented 8 years ago

Yep, I do think it's an ordering issue. I'll try get more proof and in such case I'll report it on the Atom repo since this kind of issues should be handled by them (I don't think you are able to control the packaging activation order).