analogcode / Swift-Radio-Pro

Professional Radio Station App for iOS!
MIT License
2.87k stars 712 forks source link

modified code uses lazy initialization for playableContentManager #184

Closed drajaygeorge closed 1 year ago

fethica commented 1 year ago

Hi @drajaygeorge thanks for the changes to the implementation.

However we'd appreciate it if you could provide more information on why these changes are an improvement to the current implementation. Changing if to guard may enhance readability, I noticed that you also changed guard to if on line 112, which seems to contradict the original purpose of the change. Also, I'm not entirely sure that the new setup function is more readable.

It seems that these changes were made automatically, and there may be room for further improvement. Please feel free to reopen this PR if you have any additional ideas on how to make these changes even better. Thanks!