CN0503 Platform Fluorescence Decay Support

analogdevicesinc / EVAL-ADICUP3029

This repo includes examples which run on the EVAL-ADICUP3029 ARM Cortex-M3 processor development platform from Analog Devices.

https://wiki.analog.com/resources/eval/user-guides/eval-adicup3029

Other

38 stars 63 forks source link

CN0503 Platform Fluorescence Decay Support #88

Closed NSagan271 closed 3 years ago

NSagan271 commented 3 years ago

Add support for four fluorescence-decay-related commands in the CN0503 firmware (in which, the decay of a fluorophore is measured over a period of time after an initial LED pulse.) See commit 249690f for a lengthy description of the command functionality, as well as helper functions implemented from each command.

In gpio.c, add a function to register an interrupt handler to a GPIO pin. This allows the fluorescence decay measurements to use an interrupt-based FIFO sampling method.

In flash.c, fix a few bugs regarding the use of the flash address (as far as I can tell, the flash address was used to represent a byte index in some places, and a word index in others).

adrimbarean commented 3 years ago

I think the last commit can be merged with the previous one and a force push done.

NSagan271 commented 3 years ago

We need to make sure the license from the Matlib file is compatible with ours. Standing by until it's clear.

The license for the library is here. If it isn't compatible with ours, I do not have to use it. I'm only doing 2-by-2 matrix operations, which are reasonable to implement myself.

NSagan271 commented 3 years ago

Updated PR, addressing all comments. Notes:

I removed the Matlib library; it ended up being simpler to implement to needed functionality myself.
I needed to modify one line in irq.c for setting the interrupt polarity in order to get interrupts to work.
Is there any way to re-run the checks? It seems like Azure failed to allocate resources for the checks, so they were cancelled (resolved).

mchindri commented 3 years ago

Updated PR, addressing all comments. Notes:

I removed the Matlib library; it ended up being simpler to implement to needed functionality myself.

I needed to modify one line in irq.c for setting the interrupt polarity in order to get interrupts to work.

Is there any way to re-run the checks? It seems like Azure failed to allocate resources for the checks, so they were cancelled.

There is an issue on azure for the pipelines. https://status.dev.azure.com/ When it is fixed, the checks can be retriggered

NSagan271 commented 3 years ago

Moved changes to driver files to separate commits.