stages/03.system-users-and-autologin/01.create-system-users: Change hostname to 'analog'. - Githubissues

analogdevicesinc / adi-kuiper-gen

Tool used to create ADI Kuiper Linux userspace images (based on Raspbian/raspberrypi.org )

BSD 3-Clause "New" or "Revised" License

12 stars 8 forks source link

stages/03.system-users-and-autologin/01.create-system-users: Change hostname to 'analog'. #142

Closed mlradu closed 4 months ago

mlradu commented 4 months ago

Pull Request Description

Change hostname from 'kuiper' to 'analog'.

PR Type

[x] Bug fix (change that fixes an issue)
[ ] New feature (change that adds new functionality)
[ ] Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

[x] I have performed a self-review of the changes
[ ] I have commented my code, at least hard-to-understand parts
[x] I have built Kuiper Linux image with the changes
[ ] I have tested new image in hardware, on relevant boards
[x] I have signed off all commits from this PR
[ ] I have updated the documentation (wiki pages, ReadMe etc)

SRaus commented 4 months ago

In future, try to fit commit title in max 72 characters since the rest of the text will go automatically on description. Is a good practice that in commit description to add also the answer to "Why?" the change is needed, beside "What?" was the change - in your case, to match with the initial machine name because scripts and tests that use the machine name variable are failing now.