search

analogdevicesinc / alice

Active Learning Interface for Circuits and Electronics
Other
16 stars 4 forks source link

Typo in code for Alice Desktop for macOS #13

Closed scottprahl closed 3 years ago

scottprahl commented 3 years ago

Lines 334 and 335 in alice-desktop-1.3-pyw (9-14-2020) on the version-1.3 branch should read

menubar = tkinter.Menu(root)
appmenu = tkinter.Menu(menubar, name='apple')

This only affects macOS code since the windowing system must be aqua. This has been validated under python 3.7.6 on macOS 10.14.6.

To support python2, then 334-335 looks like it might need to be

if sys.version_info[0] == 2:
    menubar = tKinter.Menu(root)
    appmenu = tKinter.Menu(menubar, name='apple')
else:
    menubar = tkinter.Menu(root)
    appmenu = tkinter.Menu(menubar, name='apple')

This is untested because my python 2.7.16 fails due to pysmu library issues.

damercer commented 3 years ago

Thanks for checking this out on Mac. I personally done own a Mac so some one else within the ADI software group would have needed to check.

Will incorporate in next release.

Doug

damercer commented 3 years ago

fixed in release 1.3.9