search

analogdevicesinc / gr-iio

IIO blocks for GNU Radio
GNU General Public License v3.0
94 stars 62 forks source link

Uneeded unique lock initialization? #116

Closed Throwaway8 closed 10 months ago

Throwaway8 commented 10 months ago

https://github.com/analogdevicesinc/gr-iio/blob/c89d543cd320df852bb76cd376c2dc3f52532dc0/lib/device_source_impl.cc#L111

boost::unique_lock lock(iio_mutex);

Maybe I am wrong and its is being used elsewhere but it seems like this wraps the mutex as a unique_lock type from boost but is never used, maybe it could be removed.

Throwaway8 commented 10 months ago

creating the lock automatically locks it