search

analogdevicesinc / gr-iio

IIO blocks for GNU Radio
GNU General Public License v3.0
94 stars 62 forks source link

Fix grc install destination #64

Closed seanstone closed 4 years ago

seanstone commented 4 years ago

Fix grc install destination because GRC_BLOCKS_DIR is no longer defined in the top-level CMakeLists.txt

NOTE: a successful CMake configuration requires this fix to FindLOG4CPP.cmake in GNURadio 3.8: https://github.com/gnuradio/gnuradio/commit/12de35d23071fe957ed78078fcbda99d2fc38207

commodo commented 4 years ago

it's a good idea to squash them; no need to have fix commits in master, if we haven't merged it yet;

also:

  1. missing Signed-off-by line in commit[s]
  2. the description of the PR could also go in the commit description; the PR desc only lives in github; it's a bit more useful to also have in the git log

rest looks good

seanstone commented 4 years ago

it's a good idea to squash them; no need to have fix commits in master, if we haven't merged it yet;

also:

  1. missing Signed-off-by line in commit[s]
  2. the description of the PR could also go in the commit description; the PR desc only lives in github; it's a bit more useful to also have in the git log

rest looks good

Ok. Got it fixed.

commodo commented 4 years ago

Will leave @tfcollins to take a look. I think he has a better handle on this than I do.

But from my side this looks good.

Thanks Alex

tfcollins commented 4 years ago

Thanks for the update.

IMHO setting the GRC_BLOCKS_DIR variable is correct since it is better for cross-platform support, even through most OOTs don't do it. Anyway, thanks again.