analogdevicesinc / hdl

HDL libraries and projects
https://wiki.analog.com/resources/fpga/docs/hdl
Other
1.53k stars 1.52k forks source link

library/axi_ltc2387/axi_ltc2387.v: Fix default value for parameters #1492

Closed IuliaCMoldovan closed 3 weeks ago

IuliaCMoldovan commented 1 month ago

PR Description

Fixed the default value for the parameters. This way it removes Critical Warnings from the project CN0577/Zed. It should actually be ADC_RES=18 and OUT_RES=32.

Tested in hardware with Linux, but not with what's latest on main. That is because there were some changes done in the past month, which affected the functionality of this project. I tested with the HEAD being at analogdevicesinc/linux@55546255ca63ded5c86f0040801cafa15459a2a8 (the commit right before the changes) and it works as expected.

PR Type

PR Checklist

IuliaCMoldovan commented 1 month ago

Tested it in hardware together with this change https://github.com/analogdevicesinc/linux/pull/2620 and it works as expected