analogdevicesinc / libiio

A cross platform library for interfacing with local and remote Linux IIO devices
http://analogdevicesinc.github.io/libiio/
GNU Lesser General Public License v2.1
490 stars 317 forks source link

iio.h here needs to be synced to upstream kernel. #1130

Closed rgetz closed 9 months ago

rgetz commented 10 months ago
looking for iio_chan_type
Differences in iio_chan_type
none
looking for iio_modifier
Differences in iio_modifier
--- /tmp/libiio_iio_modifier    2024-01-24 13:07:49.996757506 +0000
+++ /tmp/kernel_iio_modifier    2024-01-24 13:07:49.996757506 +0000
@@ -35,6 +35,8 @@
    IIO_MOD_CO2,
    IIO_MOD_VOC,
    IIO_MOD_LIGHT_UV,
+   IIO_MOD_LIGHT_UVA,
+   IIO_MOD_LIGHT_UVB,
    IIO_MOD_LIGHT_DUV,
    IIO_MOD_PM1,
    IIO_MOD_PM2P5,
difference between upstream kernel types.h and iio.h in iio_modifier
looking for iio_event_type
Differences in iio_event_type
none
looking for iio_event_direction
Differences in iio_event_direction
none

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/iio/types.h includes those two.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/iio/industrialio-core.c says names should be:

[IIO_MOD_LIGHT_UVA] = "uva",
[IIO_MOD_LIGHT_UVB] = "uvb",
rgetz commented 10 months ago

Looks like (correctly) they should be added to the end, not in the middle...

https://lore.kernel.org/all/20240123-uva_uvb_fix-v1-1-5b9c25d50d90@gmail.com/T/

rgetz commented 9 months ago

Closing based on #1132