Fix Windows Builds - Githubissues

cristina-suteu commented 3 months ago

PR Description

As things was before, for the windows deps an archive was downloaded from swdownloads. Said archive contains windows deps compiled with MinGW. The installer is created based on the MSVC builds. Both MSVC and MinGW builds were using deps from this archive compiled with MinGW. While the project seemed to be building okay, this caused problems which were visible in both installer and MSVC libiio zips at runtime. By adding a new archive with deps compiled with MSVC to be used when building libiio with MSVC, the issue is resolved. Moreover, a check for the compiler used was added in the windows build script. This ensures the correct paths to libiio's deps according to the compiler used. This fixes issue https://github.com/analogdevicesinc/libiio/issues/1174

PR Type

[x] Bug fix (a change that fixes an issue)
[ ] New feature (a change that adds new functionality)
[ ] Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

[ ] I have conducted a self-review of my own code changes
[ ] I have commented new code, particularly complex or unclear areas
[ ] I have checked that I did not introduced new warnings or errors (CI output)
[ ] I have checked that components that use libiio did not get broken
[ ] I have updated the documentation accordingly (GitHub Pages, READMEs, etc)

rgetz commented 2 months ago

As things was before - was sort of fragile and is sort of iffy from a licensing standpoint...

replicating it might not be the right path forward.

cristina-suteu commented 2 months ago

As things was before - was sort of fragile and is sort of iffy from a licensing standpoint...

replicating it might not be the right path forward.

I agree. We should provide the complete build recipe for deps and libiio itself. The purpose of this PR is to fix the issue which was reported. This is more of a hot-fix, than a long term solution, so people can download and use the windows installers. If this is not that urgent, I can close this and address this issue and the entire build recipe in a different PR. @mhennerich , @dNechita , @tfcollins , what do you think ?

tfcollins commented 2 months ago

Providing the complete build would address the licensing issue. The installer probably needs to be checked that it does reference anything packaged as well

rgetz commented 2 weeks ago

I think this is replaced by #1197 and this can be closed (without merging)?

analogdevicesinc / libiio

Fix Windows Builds #1183

PR Description

PR Type

PR Checklist