analogdevicesinc / msdk

Software Development Kit for Analog Device's MAX-series microcontrollers
Apache License 2.0
60 stars 75 forks source link

fix(PeriphDrivers): Fix `MXC_SYS_GetUSN` Buffer Overflow #1016

Closed Jake-Carter closed 2 weeks ago

Jake-Carter commented 1 month ago

Description

Fixes #1006

This PR updates MXC_SYS_GetUSN to prevent buffer overflow. The application-side buffer should be MXC_SYS_USN_LEN, but we were using MXC_SYS_USN_CHECKSUM_LEN which is a larger buffer size with some additional padding used for the internal CRC calculation.

Checklist Before Requesting Review

EricB-ADI commented 3 weeks ago

Can we get this reviewed and merge this in?

Jake-Carter commented 3 weeks ago

Can we get this reviewed and merge this in?

Yep, ready for review