Closed Jacob-Scheiffler closed 6 months ago
This pull request is stale because it has been open for 30 days with no activity. Remove stale label, commit, or comment or this will be closed in 7 days.
Just a recommendation. If the code is compiled in debug mode, it should probably just return.
Just came across this looking at open PRs. A recommendation as an end user: Add the word Permanent to the function name. Two reasons:
The MAX32672 for example has the ability to both lock the DAP with unlock capabilities, and permanently lock it. It might be nice to expose the "temporary" lock capabilities of devices the MXC_SYS_LockDAP & MXC_SYS_UnlockDAP calls. And explicitly call out Permanent in this implementation.
Just a recommendation. If the code is compiled in debug mode, it should probably just return.
Just came across this looking at open PRs. A recommendation as an end user: Add the word Permanent to the function name. Two reasons:
- Developers tend to look at function names and implement and only read the documentation later when stuff doesn't work
- Some devices have both temporary and permanent locking features
The MAX32672 for example has the ability to both lock the DAP with unlock capabilities, and permanently lock it. It might be nice to expose the "temporary" lock capabilities of devices the MXC_SYS_LockDAP & MXC_SYS_UnlockDAP calls. And explicitly call out Permanent in this implementation.
Will take a stab at the MAX32672 in a future PR
Adding a new function which will PERMANENTLY lock the debug access port. This was requested by Jim, otherwise I think it would be unwise to expose this to customers.