search

analogdevicesinc / msdk

Software Development Kit for Analog Device's MAX-series microcontrollers
Apache License 2.0
60 stars 76 forks source link

fix(PeriphDrivers, Examples): MSDK-1232: Update I2S driver for confused usage of wsize and bits_word register fields #847

Closed ahmetalincak closed 6 months ago

ahmetalincak commented 8 months ago

Description

Fix I2S Peripheral Driver for mixed usage of sample_size and bits_word registers. As described in the related Jira tickets, there was a confused usage for the word size and bits_word.

image

image

I updated all I2S examples to use new changes and made them buildable. I am going to open a new PR for examples after my changes are approved.

ahmetalincak commented 7 months ago

Also fixes the #762 .

ahmetalincak commented 7 months ago

Hi @Jake-Carter and @sihyung-maxim. After our discussions, I decided to create another PR so that we can compare and pick one solution. Please see #878 for details.

After deciding on the solution, I'll merge the developments on examples.

sihyung-maxim commented 6 months ago

Everything else looks good, by the way.

ahmetalincak commented 6 months ago

Hi @Jake-Carter, thanks for the latest change!

Jake-Carter commented 6 months ago

Hi @Jake-Carter, thanks for the latest change!

No problem!