analogdevicesinc / msdk

Software Development Kit for Analog Device's MAX-series microcontrollers
Apache License 2.0
61 stars 81 forks source link

feat(PeriphDrivers): Add SPI v2 support to MAX32690 #964

Closed sihyung-maxim closed 6 months ago

sihyung-maxim commented 6 months ago

Description

This PR adds SPI v2 support to MAX32690.

Checklist Before Requesting Review

sihyung-maxim commented 6 months ago

The Build_Examples workflow is failing because it can't find the new SPI source files... Had this same issue when the AI87 SPI v2 dirivers were added. It doesn't seem like the runner references the PR's Libraries?

Jake-Carter commented 6 months ago

The Build_Examples workflow is failing because it can't find the new SPI source files... Had this same issue when the AI87 SPI v2 dirivers were added. It doesn't seem like the runner references the PR's Libraries?

@sihyung-maxim I can replicate the error if I build PeriphDrivers for v1 and try to build the v2 example immediately afterwards. The build system doesn't know to re-build the library if settings have changed across different projects.

We worked around this with Cordio by modifying the name/filepath of the library file itself. i.e. max32655_baremetal_T2_softfp vs max32655_freertos_T1_hardfp.

I implemented this for the PeriphDrivers in https://github.com/analogdevicesinc/msdk/pull/964/commits/71bf46a993c80dcbb64aa414412120eaf1cebf12