adis scale rework - Githubissues

analogdevicesinc / no-OS

Software drivers in C for systems without an operating system

http://analogdevicesinc.github.io/no-OS/

Other

882 stars 1.63k forks source link

adis scale rework #2116

Closed rbolboac closed 4 months ago

rbolboac commented 4 months ago

Pull Request Description

Rename adis_chan_type to adis_iio_chan_type and adis_debug_attrs to adis_iio_debug_attrs to match the file name.
Currently the scale implementation is not optimal: the arrays used for scale which are defined in the chip specific drivers have a bigger size than needed because device id is used. This change removes this problem by using a device id with no offset in each chip specific driver.

PR Type

[x] Bug fix (change that fixes an issue)
[ ] New feature (change that adds new functionality)
[ ] Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

[x] I have followed the Coding style guidelines
[x] I have performed a self-review of the changes
[x] I have commented my code, at least hard-to-understand parts
[x] I have build all projects affected by the changes in this PR
[x] I have tested in hardware affected projects, at the relevant boards
[x] I have signed off all commits from this PR
[x] I have updated the documentation (wiki pages, ReadMe etc), if applies

rbolboac commented 4 months ago

do the unit tests also need an update after this rework?

yes, I am working on that

rbolboac commented 4 months ago

changed second commit message to better explain what was done