drivers:adc:ad7124:Fixing Bad Comparison

D-Disha commented 5 months ago

Fixing condition check for ID register value.

Pull Request Description

Please replace this with a detailed description and motivation of the changes. You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR. If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

[x] Bug fix (change that fixes an issue)
[ ] New feature (change that adds new functionality)
[ ] Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

[x] I have followed the Coding style guidelines
[x] I have performed a self-review of the changes
[x] I have commented my code, at least hard-to-understand parts
[x] I have build all projects affected by the changes in this PR
[x] I have tested in hardware affected projects, at the relevant boards
[x] I have signed off all commits from this PR
[x] I have updated the documentation (wiki pages, ReadMe etc), if applies

rbolboac commented 5 months ago

please also add a fixes tag with the commit that is fixed

rbolboac commented 5 months ago

Fixes tag should be immediately above Signed-off-by tag, and there should be a spae between the fixes tag and the commit sha, also, the title of the fixed commit should be full, as shown in the commit history. This is how the commit message should look like:

drivers:adc:ad7124:Fixing Bad Comparison

Fixing condition check for ID register value.

Fixes: 6d75bc3 ("drivers:ad7124:Functional changes")
Signed-off-by: Disha D <Disha.D@analog.com>

D-Disha commented 5 months ago

Fixes tag should be immediately above Signed-off-by tag, and there should be a spae between the fixes tag and the commit sha, also, the title of the fixed commit should be full, as shown in the commit history. This is how the commit message should look like:
drivers:adc:ad7124:Fixing Bad Comparison

Fixing condition check for ID register value.

Fixes: 6d75bc3 ("drivers:ad7124:Functional changes")
Signed-off-by: Disha D <Disha.D@analog.com>

Thank you , I have made those changes now

analogdevicesinc / no-OS